Conversation
added 3 commits
February 10, 2024 06:41
Modifies calls to can.Signal constructors to use NamedSignalConversion class.
* Corrects bugs in current_state to check against string instead of hex. Retval is no longer hex * Adds rate limiting to velocity printout so the terminal isn't spammed with values * Allows for a graceful shutdown of the closed loop control portion
|
Scott seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to scripts related to the CAN DBC. Currently the DBC creation fails due to invalid class constructors and
can_dbc_example.pyfails due to improper datatype comparisons and invalid message names. The CAN DBC example script also ends in an infinite loop with no means to cleanly exit and stop the ODRive, so I've added a path to allow for a graceful shutdown of the code and ODrive.