fix(teacher): import _TEACHER_SYSTEM_PROMPT from its current module - #5756
Open
DocFurious wants to merge 1 commit into
Open
fix(teacher): import _TEACHER_SYSTEM_PROMPT from its current module#5756DocFurious wants to merge 1 commit into
DocFurious wants to merge 1 commit into
Conversation
The symbol moved to src/agent_tools/model_interaction_tools.py; the old import from src.ai_interaction raises ImportError on every teacher escalation, silently disabling skill distillation. Fixes odysseus-dev#4962
|
The following required sections are missing or incomplete. Please update the PR description to address them:
This comment is deleted automatically once all sections are complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4962.
Problem
src/teacher_escalation.py:236imports_TEACHER_SYSTEM_PROMPTfromsrc.ai_interaction, where it is no longer defined. The symbol now lives insrc/agent_tools/model_interaction_tools.py.Result: every teacher escalation raises
ImportErrorbefore the teacher isever called. Because
maybe_escalate()is fire-and-forget, the feature failssilently — no skill is distilled and the user sees nothing but a log warning.
Reproduced on
main@ cf4e240 anddev@ d8a2059 (both 2026-07-23).Fix
Point the import at the module that actually defines the constant:
Notes
This is the same change as #4962 / PR #4967. That PR appears to have been
lost rather than reverted — the fix is absent from both branches.
Verification
With the fix applied,
_call_teacher()completes against a configuredteacher endpoint and returns a valid skill payload (name, description,
when_to_use, procedure steps) that passes
evaluate_turn_regex.