refactor(routes): move vault domain into routes/vault/ subpackage#5780
refactor(routes): move vault domain into routes/vault/ subpackage#5780ydonghao wants to merge 2 commits into
Conversation
Slice 2j of the route-domain reorganization (odysseus-dev#4082/odysseus-dev#4071). Moves search_routes.py into routes/search/, leaving a backward-compat sys.modules shim. Pure file reorganization, no behavior change.
Slice 2k of the route-domain reorganization (odysseus-dev#4082/odysseus-dev#4071). Moves vault_routes.py into routes/vault/, leaving a backward-compat sys.modules shim. Pure file reorganization, no behavior change.
github-actions
Bot
added
the
ready for review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return {"context": context, "sources": sources} | ||
| except Exception as e: | ||
| logger.error(f"Standalone web search failed: {e}") | ||
| return {"context": "", "sources": [], "error": str(e)} |
| except Exception as e: | ||
| elapsed = round(time.time() - t0, 2) | ||
| logger.error(f"Search provider {provider} failed: {e}") | ||
| return {"results": [], "provider": provider, "time": elapsed, "error": str(e)} |
|
Friendly ping for review 👋 This is one of three parallel low-risk slices (#5779 search, #5780 vault, #5781 webhook). Only the vault domain moves — a single-file, 242-line domain with zero internal Both points from your #4903 review are baked in (canonical doesn't depend on shim; shim regression test included). Note on CI: The @RaresKeY @alteixeira20 — would you mind taking a look when you have a moment? |
2 participants
Summary
Slice 2k of the route-domain reorganization (Refs #4082 / #4071). Moves the vault domain (242 lines) into
routes/vault/behind asys.modulesshim. Pure file reorganization, no behavior change.One of three parallel low-risk slices (search, vault, webhook). The
sys.modulesshim handles theimport ... as vr+monkeypatch.setattrpattern. Zero path-string landmines. Canonical module imports only fromcore/,src/, and stdlib.How to test
Target branch
dev, notmain.Linked Issue
Follows the Phase 0 architecture refactor (#4082 / #4071). One domain per PR.
Type of Change
Checklist
dev