feat: FFmpegエラーハンドリングPhase1 - 事前検証とクリーンアップ処理を追加#16
Merged
Conversation
- validate-output-path関数を追加: ffmpeg実行前の出力パス検証 - cleanup-partial-output関数を追加: 失敗時の部分的出力ファイル削除 - run-cmd関数を改修: 事前検証とエラー時クリーンアップを統合 - 包括的なテストケースを追加: 新機能の動作を検証 - パッケージエクスポートを更新: 新関数を外部利用可能に 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
parse-frame-rate関数は有理数(30000/1001)を返すが、テストでは 浮動小数点数(30000.0/1001)と比較していたため失敗していた。 テストを有理数同士の比較に修正。 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FFmpegエラーハンドリング改善の第1段階として、事前検証とクリーンアップ処理を実装しました。
• 事前検証:
validate-output-path関数で出力ディレクトリの存在確認とパス検証• クリーンアップ処理:
cleanup-partial-output関数で失敗時の部分的出力ファイル削除• run-cmd改修: 既存の実行フローに検証とクリーンアップを統合
Test plan
🤖 Generated with Claude Code