feat: add cloud_init_config and snap-safe temp file handling - #7
Open
miciav wants to merge 13 commits into
Open
Conversation
- Fix SnapshotInfo.from_snapshots_json to match actual Multipass CLI format
(nested dict info.{instance}.{snap_name} instead of flat list)
- Fix cpu_count parsing to handle empty string on stopped VMs
- Update integration tests disk size 3G→5G (Ubuntu 22.04 minimum)
- Add 8 new integration test scenarios: resources, suspend/resume,
file transfer, snapshot/restore, clone, cloud-init, error handling
- Update unit test fixtures to use correct snapshot JSON format
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds cloud_init_config to launch() accepting a dict (serialized to JSON) or a raw YAML string. Temp files are written to Path.home() instead of /tmp so Multipass installed via snap can access them. File is deleted automatically after launch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloud_init_configparameter tolaunch(), accepting adict(serialized to JSON) or a raw YAML stringPath.home()instead of/tmpso Multipass installed via snap can access themcloud_initfile path parameter unchangedTest plan
test_launch_with_cloud_init_config_dict— verifies dict content written correctly and temp file cleaned uptest_launch_with_cloud_init_config_str— verifies YAML string written as-is and temp file cleaned up🤖 Generated with Claude Code