Skip to content

Feature/warn if dex is enabled in production#13

Closed
olajideolamide wants to merge 3 commits into
mainfrom
feature/warn-if-dex-is-enabled-in-production
Closed

Feature/warn if dex is enabled in production#13
olajideolamide wants to merge 3 commits into
mainfrom
feature/warn-if-dex-is-enabled-in-production

Conversation

@olajideolamide
Copy link
Copy Markdown
Owner

Summary

Warn if dex is in production
Jump to issue if issue id is included in URL

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

Summary by CodeRabbit

  • New Features

    • Added deep-linking support to open specific issues directly via query parameters.
  • Improvements

    • Issues list page now displays environment mode and production status indicators instead of static description.
  • Chores

    • Updated demo link in README.
    • Removed website link from footer.

Walkthrough

The PR adds environment detection to the DEX issues interface, displaying production vs. development status on the page. It implements query-parameter-based deep-linking to open specific issue dialogs directly. Footer, layout markup, and supporting code are refined.

Changes

Environment Status and Issue Deep-Linking

Layer / File(s) Summary
Environment detection and configuration
src/Controllers/Issues.php
Issues controller reads CI_ENVIRONMENT from process environment, normalizes it to lowercase, and derives isDexRunningInProduction boolean before passing both to the view.
Environment status subtitle rendering
src/Views/dex/issues_list.php
Issues list template replaces static subtitle with conditional rendering: production badge labeled "Secure DEX" with tooltip when in production, or environment-name badge showing current environment mode otherwise.
Issue dialog deep-linking
src/Views/dex/_js.php
JavaScript initializer parses issue_id from query parameter and tracks open state. During render, dexIssuesTryOpenDeepLinkedIssue() guards against repeated opens and interfering dialogs, locates the matching table row by data-id, and opens the dialog.
Layout and footer refinements
src/Views/dex/layout.php, src/Views/dex/issues_dialog_shell.php, src/Controllers/Issues.php
Page container positioning adjusted, website footer link removed, dialog method array formatting fixed, and dialog shell spacing adjusted.
Demo link update
README.md
README demo link updated to point to https://dex.profusionlabs.org.

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A rabbit hops through environments deep,
Production badges and modes to keep,
Deep-linking dialogs with query delight,
Footer links trimmed, the layout just right!
✨ DEX dances in production and dev.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete; it lacks the 'Changes', 'How to test', and 'Checklist' sections required by the template. Complete the description by adding a bulleted list of changes, testing instructions, and a checklist with relevant items marked.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main feature—warning when DEX is enabled in production—which aligns with the primary changes in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/warn-if-dex-is-enabled-in-production

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@olajideolamide olajideolamide deleted the feature/warn-if-dex-is-enabled-in-production branch May 21, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants