support is for CI 4.3.5 and higher#15
Merged
Merged
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Hidden review stack artifactWalkthroughExpands CI to run PHPStan and PHPUnit across PHP versions and dependency modes using a shared install script, adds an advisory PHP 8.5 PHPUnit job, tightens composer validation, and updates composer + docs to require CodeIgniter 4.6.2. ChangesCI/CD Infrastructure & Testing Expansion
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/phpstan.yml:
- Line 24: The workflow currently uses tag-pinned actions; replace the two
occurrences "uses: actions/checkout@v4" and "uses: shivammathur/setup-php@v2"
with their corresponding full commit SHAs (e.g.,
actions/checkout@<full-commit-sha> and shivammathur/setup-php@<full-commit-sha>)
so the workflow is pinned to immutable revisions; locate the uses: lines for
actions/checkout and shivammathur/setup-php in the YAML and substitute the tag
with the exact commit SHA from each action's repository.
In @.github/workflows/phpunit.yml:
- Line 24: The workflow uses tag-based action references (e.g.,
actions/checkout@v4 and shivammathur/setup-php@v2), which should be replaced
with immutable commit SHAs to satisfy supply-chain/policy requirements; update
each occurrence (actions/checkout@v4, shivammathur/setup-php@v2 and the other
listed uses at lines 30, 83, 89, 142, 148, 175, 181) to the corresponding action
repository commit SHA (found in the action's GitHub repo releases or tags),
replacing the tag with the full SHA for each uses: entry so the workflow
references a fixed immutable version.
In `@docs/content/getting-started/installation.md`:
- Line 12: The markdown bold syntax for the dependency line is missing the
trailing marker; locate the text string "**CodeIgniter 4.3.5 or higher" in the
getting-started installation content and add the closing "**" so it reads
"**CodeIgniter 4.3.5 or higher**".
In `@tests/Support/Config/Registrar.php`:
- Line 109: The file tests/Support/Config/Registrar.php ends with two blank
lines which violates PSR-12/PSR-2; open Registrar.php and remove the extra
trailing blank line so the file ends with exactly one newline character (single
blank line at EOF), save, and re-run PHPCS/CI to confirm the formatting fix.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5194cf70-465a-48b9-83a2-ab84edc6921f
📒 Files selected for processing (8)
.github/scripts/install-dependencies.sh.github/workflows/phpstan.yml.github/workflows/phpunit.ymlCONTRIBUTING.mdREADME.mdcomposer.jsondocs/content/getting-started/installation.mdtests/Support/Config/Registrar.php
There was a problem hiding this comment.
♻️ Duplicate comments (2)
.github/workflows/phpstan.yml (1)
25-25:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPin action references to immutable commit SHAs.
Both
uses:entries are tag-pinned and mutable. Pin them to full SHAs to harden the workflow supply chain.#!/bin/bash set -euo pipefail FILE=".github/workflows/phpstan.yml" echo "Checking $FILE" rg -n '^\s*-\s*uses:\s*' "$FILE" python3 - <<'PY' import re, pathlib p = pathlib.Path(".github/workflows/phpstan.yml") uses_re = re.compile(r'^\s*-\s*uses:\s*([^\s#]+)') sha_re = re.compile(r'@[0-9a-fA-F]{40}$') for i, line in enumerate(p.read_text().splitlines(), 1): m = uses_re.match(line) if not m: continue ref = m.group(1) status = "SHA_PINNED" if sha_re.search(ref) else "NOT_PINNED" print(f"{i}: {status} -> {ref}") PYExpected result: every
uses:line reportsSHA_PINNED.Also applies to: 31-31
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/phpstan.yml at line 25, The workflow uses entries are pinned to mutable tags (e.g., "actions/checkout@v4") instead of immutable commit SHAs; update each "uses:" entry in the phpstan.yml workflow (including the line referencing actions/checkout@v4 and the other uses entry around line 31) to the corresponding full 40-character commit SHA (replace the `@tag` with @<40-char-sha>) so every uses: reference is SHA_PINNED..github/workflows/phpunit.yml (1)
25-25:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPin all action references to immutable commit SHAs.
These
uses:entries are tag-pinned and can drift. Replace them with full commit SHAs for deterministic and safer CI runs.#!/bin/bash set -euo pipefail FILE=".github/workflows/phpunit.yml" echo "Checking $FILE" rg -n '^\s*-\s*uses:\s*' "$FILE" python3 - <<'PY' import re, pathlib p = pathlib.Path(".github/workflows/phpunit.yml") uses_re = re.compile(r'^\s*-\s*uses:\s*([^\s#]+)') sha_re = re.compile(r'@[0-9a-fA-F]{40}$') for i, line in enumerate(p.read_text().splitlines(), 1): m = uses_re.match(line) if not m: continue ref = m.group(1) status = "SHA_PINNED" if sha_re.search(ref) else "NOT_PINNED" print(f"{i}: {status} -> {ref}") PYExpected result: every
uses:line reportsSHA_PINNED.Also applies to: 31-31, 84-84, 90-90, 143-143, 149-149, 176-176, 182-182
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/phpunit.yml at line 25, Replace all tag-pinned GitHub Action references in the workflow's uses: lines (e.g., uses: actions/checkout@v4) with immutable full 40-character commit SHAs (e.g., actions/checkout@<40-char-SHA>); find every uses: entry (including the ones flagged like actions/checkout and other actions around the reported lines) and update the ref to the exact commit SHA for that action repository so CI runs are deterministic.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In @.github/workflows/phpstan.yml:
- Line 25: The workflow uses entries are pinned to mutable tags (e.g.,
"actions/checkout@v4") instead of immutable commit SHAs; update each "uses:"
entry in the phpstan.yml workflow (including the line referencing
actions/checkout@v4 and the other uses entry around line 31) to the
corresponding full 40-character commit SHA (replace the `@tag` with
@<40-char-sha>) so every uses: reference is SHA_PINNED.
In @.github/workflows/phpunit.yml:
- Line 25: Replace all tag-pinned GitHub Action references in the workflow's
uses: lines (e.g., uses: actions/checkout@v4) with immutable full 40-character
commit SHAs (e.g., actions/checkout@<40-char-SHA>); find every uses: entry
(including the ones flagged like actions/checkout and other actions around the
reported lines) and update the ref to the exact commit SHA for that action
repository so CI runs are deterministic.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6ca4abd5-e55c-4643-84b7-fa2e34f5f8ea
📒 Files selected for processing (10)
.github/scripts/install-dependencies.sh.github/workflows/phpcs.yml.github/workflows/phpstan.yml.github/workflows/phpunit.ymlCONTRIBUTING.mdREADME.mdcomposer.jsondocs/content/getting-started/installation.mdtests/Support/Config/Registrar.phptests/Support/DexTestCase.php
💤 Files with no reviewable changes (1)
- tests/Support/Config/Registrar.php
✅ Files skipped from review due to trivial changes (3)
- README.md
- CONTRIBUTING.md
- docs/content/getting-started/installation.md
Owner
Author
|
@coderabbitai resolve |
✅ Actions performedComments resolved and changes approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support CI from v4.3.5 and higher