Домашняя работа, Куликов Артём#1
Open
AveZorgen wants to merge 5 commits into
Open
Conversation
AveZorgen
commented
Apr 17, 2024
AveZorgen
commented
- Санитайзеры и статические анализаторы задействованы
- Исправлены баги
- Написаны тесты
We should destroy stack after usage
destroyStack: null stack top at the end pop: free popped block searchByValue: make shorter also there was ininite loop searchByIndex: make shorter isEmpty: delete free while empty checking
olegrok
reviewed
Apr 17, 2024
olegrok
left a comment
olegrok
left a comment
Owner
There was a problem hiding this comment.
Здорово. Оставил несколько небольших комментариев.
olegrok
reviewed
Apr 18, 2024
No elements - nothing to pop - no job
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.