Use the same build tags in wgpuglfw as in glfw for linux (x11 and wayland by default)#3
Closed
rcoreilly wants to merge 3 commits into
Closed
Use the same build tags in wgpuglfw as in glfw for linux (x11 and wayland by default)#3rcoreilly wants to merge 3 commits into
rcoreilly wants to merge 3 commits into
Conversation
Author
|
Ok, now doing it the other way -- linux automatically supports both! |
Owner
|
Actually the existing code should already support all four combinations. No tags for both platforms, either only x11 or wayland and also both tags. It does work with the updated glfw branch. |
Author
|
ok yeah now I see.. sorry again :) |
Owner
|
No reason to be sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this makes any difference but anyway it seems like the right thing to do, correct?
@oliverbestmann you might want to make sure your "watching" settings are on so I don't have to keep tagging you :)