Simplify antenna on neobread_bot#5
Open
o76923 wants to merge 2 commits into
Open
Conversation
The x and y on the eye filter should be reduced to -2 since the width and height are 5 now. 2 to the left of the object + the object + 2 to the right of the object = 5 total object widths.
olivvybee
reviewed
Sep 30, 2024
| <svg width="100%" height="100%" viewBox="0 0 256 256" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" xml:space="preserve" xmlns:serif="http://www.serif.com/" style="fill-rule:evenodd;clip-rule:evenodd;stroke-linecap:round;stroke-linejoin:round;stroke-miterlimit:1.5;"> | ||
| <defs> | ||
| <filter id="eye_glow" width="10" height="10" x="-5" y="-5"> | ||
| <filter id="eye_glow" width="5" height="5" x="-2" y="-2"> |
Author
There was a problem hiding this comment.
It doesn't need to, strictly speaking, it just creates an unnecessarily large box in editors like Inkscape that can make it awkward to work with. I've been trying to trim it down as much as possible.
I think 4 is probably the tightest it can go and still have no impact even at 2048×2048 but that would leave you at x="-1.5" and y="-1.5" so I've just been doing it at 5 width instead. I think I pushed that change to the official neobot SVGs already...
Owner
There was a problem hiding this comment.
Makes sense, I'll include it!
in general it's good to describe all your changes in the PR description otherwise there are little surprise nuggets that may not be obvious from the diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path on the outline was so complicated that it was driving me nuts. I replaced it with a greatly simplified version.