This repository was archived by the owner on Dec 22, 2018. It is now read-only.
fixed mismatch (closeAny & closeOther) on accordion code#4
Open
engineervix wants to merge 3 commits intoolton-archive:masterfrom
Open
fixed mismatch (closeAny & closeOther) on accordion code#4engineervix wants to merge 3 commits intoolton-archive:masterfrom
engineervix wants to merge 3 commits intoolton-archive:masterfrom
Conversation
There was a mismatch on the accordion option and the implementation. The option says `closeAny` while the implementation was referring to `closeOther`, so I changed the option to `closeOther` -- which is consistent with the [current docs](https://coreui.net/docs.html#accordion).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a mismatch between the accordion option and the implementation. The option says
closeAnywhile the implementation was referring tocloseOther, so I changed the option tocloseOther-- which is consistent with the current docs.