feat(explorer): basic file management with drag & drop - #37
Open
thePlannerIvan wants to merge 1 commit into
Open
feat(explorer): basic file management with drag & drop#37thePlannerIvan wants to merge 1 commit into
thePlannerIvan wants to merge 1 commit into
Conversation
Add VSCode-explorer-parity file management to the sidebar file tree:
- New file / new folder: hover buttons on folder rows and the root row,
plus context-menu entries; inline name input (Enter commits, Esc cancels,
collapsed parents auto-expand).
- Rename: context menu opens an inline input on the row.
- Delete: context menu arms a two-step inline confirmation (permanent,
recursive; the session cwd itself can never be removed).
- Drag & drop: files and folders drag onto directory rows, the root row or
the explorer body to move; target rows highlight; moving into one's own
subtree is refused; affected levels refetch after every mutation.
- Host API: fs.mkdir, fs.create, fs.rename, fs.move, fs.remove — all
confined to the session cwd (isWithin, 403 otherwise), single-segment
name validation ('.', '..', '/', '\' refused), 'wx' create so existing
files are never silently overwritten.
- Explorer listing also filters macOS Finder metadata files (.DS_Store,
.localized).
Verified: typecheck, test suite (no new failures vs clean main), build.
Collaborator
|
@codex Do CR |
|
To use Codex here, create an environment for this repo. |
Collaborator
|
@codex do cr now |
Summary
Testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds VSCode-explorer-parity file management to the sidebar file tree:
Files changed
src/fs-tree.ts, src/index.ts, src/client/api.ts, src/client/ExplorerView.tsx
Verification
Notes