fix: explorer resolves symlinks to their target kind - #67
Open
NolanHo wants to merge 1 commit into
Open
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Dirent.isDirectory() does not follow symlinks, so a symlink to a directory rendered as a file row and opening it failed the editor read with EISDIR. Probe each symlink once (stat) to classify its target, badge link rows with a link icon, and flag dangling links with error ink plus a tooltip; non-symlink rows skip the probe so large levels stay cheap. Addresses the gap reported in omdsh-dev#65.
NolanHo
force-pushed
the
fix/explorer-symlink-handling
branch
from
August 14, 2026 17:51
8f1a0c8 to
595104a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dirent.isDirectory() does not follow symlinks, so a symlink to a directory rendered as a file row and opening it failed the editor read with EISDIR. Probe each symlink once (stat) to classify its target, badge link rows with a link icon, and flag dangling links with error ink plus a tooltip; non-symlink rows skip the probe so large levels stay cheap. Addresses the gap reported in #65.