fix: support Windows UNC paths in explorer and produced-file resolution - #79
Open
LuckinOvaltine wants to merge 1 commit into
Open
fix: support Windows UNC paths in explorer and produced-file resolution#79LuckinOvaltine wants to merge 1 commit into
LuckinOvaltine wants to merge 1 commit into
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, when a session's working directory is a UNC network path
(e.g.
\\server\share\project), the sidebar explorer fails to list thedirectory with
"... is not an absolute path", and the produced-file"open in sidebar" feature mis-resolves UNC paths.
requireAbsolute()only accepted/-prefixed and drive-letter (C:\)paths;
resolveSidebarPath()had the same gap in the client half.Changes
src/fs-tree.ts: use Node'spath.isAbsolute()(which returnstruefor UNC paths on win32) in
requireAbsolute().src/client/produced-files.ts: treat\\-prefixed paths as absolutein
resolveSidebarPath().tests/unit.spec.ts: add win32 cases covering UNC paths for bothhelpers.
How I verified
pnpm typecheckpasses.pnpm buildpasses (tsc + tsdown).pnpm testfailures on a localWindows machine are pre-existing platform issues (CRLF line endings,
/bin/bashvspowershell.exe, drive-letter resolution) and areunchanged by this PR.
Risks / Notes
win32platform in tests.