Skip to content

feat(advisor): dsh-tui client surface — tuiCommandTrees /advisor + /advisor config readback + docs - #53

Merged
btspoony merged 8 commits into
mainfrom
iteration/iter-20260816-dsh-advisor-n8
Aug 16, 2026
Merged

feat(advisor): dsh-tui client surface — tuiCommandTrees /advisor + /advisor config readback + docs#53
btspoony merged 8 commits into
mainfrom
iteration/iter-20260816-dsh-advisor-n8

Conversation

@btspoony

Copy link
Copy Markdown
Collaborator

iter-20260816-dsh-advisor-n8 — Advisor dsh-tui client surface

Adds a first-class dsh-tui client surface for the advisor plugin, with zero dsh-TUI changes (read-only reference @ 557a27a):

What's in

  • src/tui.ts (new) — TUI client seam: conditional ctx.inject(['tuiCommandTrees']) registration of a /advisor TuiCommandTreeProvider (root advisor, zh/en descriptions, completion children on|off|status|config). Structural types only — no @deepseek-harness-tui/dsh-tui dependency (zero new peers). Reviewer-claim gated; duplicate-root defensive catch.
  • /advisor config (read-only settings readback) — src/commands.ts + src/index.ts: new config subcommand rendering the composed advisor config (schema defaults → plugin-row base → settings user layer, hard gate applied) + edit hints (profile patch layer / global $DSH_HOME/settings.yaml). Session-less by design (parity with the web card /api/advisor/get — a /advisor off session toggle never misreports the persisted config); USAGE + registry input.hint updated. Resolver-throw containment mirrors the gateway's S1 fallback (seeds scalars from the raw source).
  • README.md / README.zh.md — new dsh-tui profile section (install / settings / commands / web-card-is-web-only limitation); README.i18n.yaml hashes re-recorded (also repaired a pre-existing stale record). docs/install.md / install.zh.md — dsh-tui profile install variant.

Verification

  • QC tri (L3): qc-specialist Approve · qc-specialist-2 Request Changes → fix wave (fallback seeding, tui-tree dedupe, prompt-summary edges, containment pin) → targeted re-review Approve — consolidated Approve clean, zero-residual.
  • QA mandatory (real dsh-tui session): dsh --profile dsh-tui --dump-config shows the advisor row; live PTY boot + /advisor status + /advisor config render correctly; session-less + inject-cycle pinned by settings-live/integration tests; 360 tests green, typecheck + build clean. Interactive remainder (menu-overlay/completion snapshot + live turn→note) documented as a human spot-check residual (qa.md).
  • Environment note: the host's dsh profile boot was repaired (node-addon-require-builtin platform binding) — knowledge-crystallized.

Related

  • Upstream feature request filed: ccch1mneyyy/dsh-TUI#165 (TUI lacks a plugin settings seam; TUI settings write surface tracked as the next iteration once unblocked).
  • Knowledge: architecture-patterns/dsh-tui-plugin-client-surface.md, developer-experience/dsh-tui-verification-and-host-boot-repair.md; CONCEPTS.md entry dsh-tui client seam.

@btspoony
btspoony merged commit 9984fd5 into main Aug 16, 2026
1 check passed
@btspoony

Copy link
Copy Markdown
Collaborator Author

Phase 5 user-directed updates (46d3571):

  • Output caps 256→5120→768 (ADVISOR_MAX_TOKENS tokens + ADVISOR_NOTE_MAX_CHARS chars) — with thinking-off the capability-gated default, the reasoning headroom is unnecessary; budget now fits one bounded note plus the JSON frame. KD-2/KD-6 supersession chain updated in the spec, docs, knowledge.
  • User-facing log de-codename: the only runtime log carrying an internal ID ((KD-2)) now reads plain semantics.
  • Development-internal content (mechanism, token/char bounds, build/peer internals) removed from the user-facing README (en + zh); Limitations & roadmap kept; i18n hashes re-recorded.
    CI validate SUCCESS on this head.

@btspoony
btspoony deleted the iteration/iter-20260816-dsh-advisor-n8 branch August 16, 2026 04:49
@btspoony btspoony mentioned this pull request Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant