feat(advisor): dsh-tui client surface — tuiCommandTrees /advisor + /advisor config readback + docs - #53
Merged
Conversation
…e dedupe + prompt summary edges (QC F-1..F-4)
…dvisor config readback + docs) — plan dsh-advisor-tui-client-n8
…+ de-codename user-facing log + dev internals out of user README
Collaborator
Author
|
Phase 5 user-directed updates (46d3571):
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iter-20260816-dsh-advisor-n8 — Advisor dsh-tui client surface
Adds a first-class dsh-tui client surface for the advisor plugin, with zero dsh-TUI changes (read-only reference @ 557a27a):
What's in
src/tui.ts(new) — TUI client seam: conditionalctx.inject(['tuiCommandTrees'])registration of a/advisorTuiCommandTreeProvider(rootadvisor, zh/en descriptions, completion childrenon|off|status|config). Structural types only — no@deepseek-harness-tui/dsh-tuidependency (zero new peers). Reviewer-claim gated; duplicate-root defensive catch./advisor config(read-only settings readback) —src/commands.ts+src/index.ts: newconfigsubcommand rendering the composed advisor config (schema defaults → plugin-row base → settings user layer, hard gate applied) + edit hints (profile patch layer / global$DSH_HOME/settings.yaml). Session-less by design (parity with the web card/api/advisor/get— a/advisor offsession toggle never misreports the persisted config);USAGE+ registryinput.hintupdated. Resolver-throw containment mirrors the gateway's S1 fallback (seeds scalars from the raw source).README.i18n.yamlhashes re-recorded (also repaired a pre-existing stale record). docs/install.md / install.zh.md — dsh-tui profile install variant.Verification
dsh --profile dsh-tui --dump-configshows the advisor row; live PTY boot +/advisor status+/advisor configrender correctly; session-less + inject-cycle pinned by settings-live/integration tests; 360 tests green, typecheck + build clean. Interactive remainder (menu-overlay/completion snapshot + live turn→note) documented as a human spot-check residual (qa.md).Related
architecture-patterns/dsh-tui-plugin-client-surface.md,developer-experience/dsh-tui-verification-and-host-boot-repair.md; CONCEPTS.md entrydsh-tui client seam.