Clarify the use of "Plane" elements in artifical example data#4
Merged
Clarify the use of "Plane" elements in artifical example data#4
Conversation
Member
Author
Member
|
Builds are green. Are these builds staged somewhere on the readthedocs infrastructure for easier review? |
Member
Author
|
https://app.readthedocs.org/projects/ome-model/ suggests that PRs aren't being staged, as they are for https://app.readthedocs.org/projects/bio-formats/. I don't think I have the permissions to change that right now. Maybe worth updating maintainer lists for both projects (in the same spirit as work related to ome/ome-model#222)? |
sbesson
approved these changes
Jul 1, 2025
Member
sbesson
left a comment
sbesson
left a comment
There was a problem hiding this comment.
I am also not part of the maintainers for the readthedocs project. I suspect this is worth a review at some point. Given the nature of the change, I am just going to merge this and we can discuss permissions in an upcoming Formats meeting /cc @jburel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ome/ome-model#73.
This is intended to clarify the current state of artificial example OME-TIFF data, in particular that there are no
Planeelements for this set of examples but that the ZCT indexes are "burned in" to the images themselves.I'm not particularly inclined to update the
MakeTestOmeTiffexample and regenerate these files (since there are other examples of how to usePlane), but can do if any strong feelings.