Merged
Conversation
sbesson
approved these changes
Feb 10, 2025
Member
sbesson
left a comment
sbesson
left a comment
There was a problem hiding this comment.
The proposed changes do not modify the code, look fairly low impact change and capture the state of the internal Python code used to generate the sources of the model and metadata classes.
Marking for inclusion in the nightly OME CI builds and proposing to get this in a few days barring objections. As discussed in #215, the expectation is that this will not become a source of noise or a maintenance burden for a portion of code that has been been unmodified in the last 5 years and for which there is no planned development at the moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 2 is debatable.
Follow-up of #215.