Skip to content

Make multiple improvements to Makefile#1011

Merged
gab-arrobo merged 2 commits intoomec-project:mainfrom
gab-arrobo:update-makefile
Feb 18, 2026
Merged

Make multiple improvements to Makefile#1011
gab-arrobo merged 2 commits intoomec-project:mainfrom
gab-arrobo:update-makefile

Conversation

@gab-arrobo
Copy link
Copy Markdown
Contributor

No description provided.

@gab-arrobo gab-arrobo requested review from a team and Copilot January 14, 2026 21:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Makefile to improve maintainability, organization, and usability. The project name is updated from upf-epc to upf, and the Makefile is reorganized with better structure, error handling, and documentation.

Changes:

  • Updated project name from upf-epc to upf and improved variable handling with fallback values
  • Reorganized Makefile with clear sections, added help system, and standardized variable syntax
  • Enhanced Docker build commands with better error handling, updated OCI labels, and added utility targets

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile Outdated
@gab-arrobo gab-arrobo marked this pull request as draft January 14, 2026 22:48
@gab-arrobo gab-arrobo closed this Feb 18, 2026
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
@gab-arrobo gab-arrobo reopened this Feb 18, 2026
@gab-arrobo gab-arrobo marked this pull request as ready for review February 18, 2026 07:50
Copilot AI review requested due to automatic review settings February 18, 2026 07:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile
Comment thread Makefile
Comment thread Makefile Outdated
Comment thread Makefile Outdated
Comment thread Makefile
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Copy link
Copy Markdown
Contributor

@sureshmarikkannu sureshmarikkannu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the changes locally and all works fine

@gab-arrobo gab-arrobo merged commit 0a2bf72 into omec-project:main Feb 18, 2026
13 checks passed
@gab-arrobo gab-arrobo deleted the update-makefile branch February 18, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants