Open
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes forward declarations in the scheduler system by adding internal function prototypes and replacing a duplicate typedef with a proper forward declaration.
- Adds internal function prototypes to prevent implicit function declarations in scheduler.c
- Replaces duplicate
actor_ttypedef with proper forward declaration ofstruct actor_context
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| kernel/kernel.h | Replaces typedef with forward declaration for actor_context struct |
| kernel/core/scheduler.c | Adds internal function prototypes to prevent implicit declarations |
| static void scheduler_remove_from_ready_queue(struct actor_context* actor); | ||
| static void actor_create_kernel_actor(void); | ||
| static bool actor_add_message(struct actor_context* actor, message_t* message); | ||
| static void actor_clear_message_queue(struct actor_context* actor); |
There was a problem hiding this comment.
The function prototype for message_allocate should include a parameter to indicate if allocation failed, or the function should be documented to clarify error handling behavior. Consider adding a comment about how allocation failure is handled.
Suggested change
| static void actor_clear_message_queue(struct actor_context* actor); | |
| static void actor_clear_message_queue(struct actor_context* actor); | |
| // Allocates a message from the pool. Returns NULL if allocation fails; caller must check for NULL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
make kernel(fails: unknown type namepaging_context_t)https://chatgpt.com/codex/tasks/task_e_6897d3a2dd24832c90f95ffcfcf47647