Independent legolink segspans cache#6
Open
omerpaz95 wants to merge 32 commits into
Open
Conversation
Signed-off-by: David Ben-David <davidb@pliops.com>
…ed-token gaps Signed-off-by: David Ben-David <davidb@pliops.com>
Signed-off-by: Kfir Wolfson <kfirw@pliops.com>
Signed-off-by: Omer Paz <omerpaz95@gmail.com>
Signed-off-by: omerpaz95 <omerpaz95@gmail.com>
Signed-off-by: omerpaz95 <omerpaz95@gmail.com>
Signed-off-by: omerpaz95 <omerpaz95@gmail.com>
…stic. Signed-off-by: omerpaz95 <omerpaz95@gmail.com>
Signed-off-by: omerpaz95 <omerpaz95@gmail.com>
Signed-off-by: omerpaz95 <omerpaz95@gmail.com>
Make block size, gap policy, gap length, and pad token configurable via VLLM_V1_SPANS_* environment variables so they can be set in Docker deployments without CLI args. Also register the missing --gap-policy-name and --gap-policy-config CLI arguments that existed as EngineArgs fields but were not exposed to argparse. New env vars: - VLLM_V1_SPANS_PAD_TOKEN - VLLM_V1_SPANS_BLOCK_SIZE - VLLM_V1_SPANS_GAP_POLICY_ENABLE - VLLM_V1_SPANS_GAP_LENGTH
Add env var configuration for span/gap-policy parameters
…e outputs on llama4.
…c inconsistency between vLLM regular path and spans path, matching the triton attention kernel's fused RoPE to the RoPE CUDA kernel
Signed-off-by: omerpaz95 <omerpaz95@gmail.com>
Signed-off-by: omerpaz95 <omerpaz95@gmail.com>
Bugfix/spans inconsistency
Signed-off-by: omerpaz95 <omerpaz95@gmail.com>
…ries Span boundaries are no longer marked by special tokens (SPAN_TOKEN_PLUS, SPAN_TOKEN_CROSS) embedded in the token stream. Instead, span_starts and cross_span_starts are passed via SamplingParams.extra_args and read by Request and SpanAwareGapPolicy directly. Signed-off-by: omerpaz95 <omerpaz95@gmail.com>
Remove span marker tokens from prompt, use extra_args for span bounda…
Signed-off-by: omerpaz95 <omerpaz95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I still have to review this thoroughly