Skip to content

double the max_header_value_length#1331

Merged
InoMurko merged 2 commits intomasterfrom
inomurko/increase_header_size
Feb 20, 2020
Merged

double the max_header_value_length#1331
InoMurko merged 2 commits intomasterfrom
inomurko/increase_header_size

Conversation

@InoMurko
Copy link
Contributor

@InoMurko InoMurko commented Feb 20, 2020

We've seen occurrences of


error] module=Plug.Cowboy function=onresponse/4 ⋅Cowboy returned 400 because it was unable to parse the request headers.
--
  | Feb 20 04:00:17.860 | This may happen because there are no headers, or there are too many headers
  | Feb 20 04:00:17.860 | or the header name or value are too large (such as a large cookie).
  | Feb 20 04:00:17.860 | You can customize those values when configuring your http/https
  | Feb 20 04:00:17.860 | server. The configuration option and default values are shown below:
  | Feb 20 04:00:17.860 | protocol_options: [
  | Feb 20 04:00:17.860 | max_header_name_length: 64,
  | Feb 20 04:00:17.861 | max_header_value_length: 4096,
  | Feb 20 04:00:17.861 | max_headers: 100,
  | Feb 20 04:00:17.861 | max_request_line_length: 8096
  | Feb 20 04:00:17.861 | ]
  | Feb 20 04:00:17.861 | ⋅


added fixes for Statix on our fork bleacherreport/statix#1

@InoMurko InoMurko requested review from 0x234 and arthurk February 20, 2020 07:13
@coveralls
Copy link

coveralls commented Feb 20, 2020

Coverage Status

Coverage increased (+0.1%) to 86.317% when pulling 040fe6c on inomurko/increase_header_size into 6e1e593 on master.

@InoMurko
Copy link
Contributor Author

config get overwritten somehow. needs fixing.

@InoMurko InoMurko force-pushed the inomurko/increase_header_size branch from 83a086b to 2ca174a Compare February 20, 2020 16:42
@InoMurko InoMurko force-pushed the inomurko/increase_header_size branch from 2ca174a to c5ccafe Compare February 20, 2020 16:43
@InoMurko InoMurko merged commit 47d63a7 into master Feb 20, 2020
@InoMurko InoMurko deleted the inomurko/increase_header_size branch February 20, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants