Set global default for success/error callbacks#56
Open
itailulu wants to merge 16 commits intoomichelsen:masterfrom
Open
Set global default for success/error callbacks#56itailulu wants to merge 16 commits intoomichelsen:masterfrom
itailulu wants to merge 16 commits intoomichelsen:masterfrom
Conversation
…cted instance injector
…smine-1.1.0 Update karma-jasmine to version 1.1.0 🚀
Owner
|
Hey, sorry for the late response. I like your idea and implementation. Would you mind working to get tests added/fixed for this? Otherwise I will try and copy it to my own PR. |
added 10 commits
January 8, 2017 23:03
pulling from master
Author
|
@omichelsen, I refactored the solution a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature allows you to set default callbacks for success/error.
Setting the callback with the directive attributes on-success and on-error will override the global default.
I'm not sure this implementation of the feature is of best practice.
Please let me know if you have better ideas or any comments on the code.