fix(auth): stop refresh-token rotation race from logging users out#12
Merged
Conversation
Concurrent SSR requests for one session each refreshed the single-use OAuth token independently; all but the winner presented a just-rotated token, and getAuth force-signed-out the still-valid session on the first failure, logging users out in bursts on every app re-open. Single-flight the refresh per session so a page-load burst triggers one rotation instead of many, and degrade instead of destroy on a refresh failure: serve the session without a fresh access token and let the natural 401 -> re-auth path recover a genuinely dead session rather than punishing a benign rotation race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fleet-wide forced re-login was a concurrent refresh-token-rotation race. On app re-open, an SSR page fires many parallel requests carrying the same session cookie; each independently refreshed the single-use OAuth token, all but the winner presented a just-rotated token, and
getAuthforce-signed-out the still-valid session on the firstinvalid_grant/FAILED_TO_GET_ACCESS_TOKEN. Confirmed in production logs (logouts arriving in bursts of ~6 within <1s).Changes
Testing
Pairs with the Gatekeeper rotation reuse grace window (defense in depth at the IDP).