fix(notifications): preserve the From display name for Herald#16
Merged
Conversation
Herald renders a `Name <email>` display name in the From header (it parses the bare address for the envelope itself), but the provider stripped `from` down to the bare address before sending, so a friendly From never reached the header. Pass `from` through unchanged; recipient fields (to/cc/bcc/replyTo) are still reduced to bare addresses, which Herald requires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Herald renders a
Name <email>display name in the From header (parsing the bare address for the envelope itself), but the provider strippedfromto the bare address, so a friendly From never reached the header. Passfromthrough; recipient fields stay bare. Requires herald-api#21 (accept display-formfrom). Tests updated.