Skip to content

fenix: do not truncate git commit message title #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
citrus-it merged 1 commit into from
Mar 30, 2026
Merged

fenix: do not truncate git commit message title #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions lib/Fenix/Model/Handler/Issue/GitHub.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,29 +23,26 @@ sub issues($self, $msg) {
}

sub issueURL($self, $issue) {
return Mojo::URL->new("/$issue.patch")->base($self->baseurl)->to_abs
return Mojo::URL->new("/$issue.json")->base($self->baseurl)->to_abs
if $issue =~ m!/commit/!;

my ($orgrepo, $hash) = split /#/, $issue, 2;

return Mojo::URL->new("/$orgrepo/commit/$hash.patch")->base($self->baseurl)->to_abs;
return Mojo::URL->new("/$orgrepo/commit/$hash.json")->base($self->baseurl)->to_abs;
}

sub processIssue($self, $issue, $res) {
my ($orgrepo) = split /#/, $issue, 2;

# we are only interested in the first 4 lines (the header), drop everything else
my @data = split /\r?\n/, $res->body, 5;
pop @data;
my $data = $res->json;

my ($fullhash) = map { /^From\s+([[:xdigit:]]+)/ } @data;
my $fullhash = $data->{payload}->{commit}->{oid};
my $hash = substr $fullhash, 0, 7;

my ($subject) = map { /^Subject:\s+\[PATCH\]\s+(.+)/ } @data;
# strip Reviewed by if it occurs on the first commit message line
$subject =~ s/\s+Reviewed.*$//;
my $subject = $data->{title};
$subject =~ s/\s+\S\s+\S+\@[[:xdigit:]]+$//;

my ($author) = map { /^From:\s+([^<]+\S)\s+</ } @data;
my $author = $data->{payload}->{commit}->{authors}->[0]->{displayName};

return {
id => $self->issuestr . " $hash",
Expand All @@ -63,7 +60,7 @@ __END__

=head1 COPYRIGHT

Copyright 2025 OmniOS Community Edition (OmniOSce) Association.
Copyright 2026 OmniOS Community Edition (OmniOSce) Association.

=head1 LICENSE

Expand Down
Loading