brand/bhyve: Add support for virtio-scsi configuration. - #532
Open
hrosenfeld wants to merge 1 commit into
Open
Conversation
hadfl
reviewed
Apr 2, 2026
citrus-it
reviewed
May 18, 2026
|
|
||
| if i < 8: | ||
| if diskif.startswith('scsi') and diskif in scsi_hba: | ||
| scsi_hba[diskif]['targets'].append(diskpath(v)) |
Member
There was a problem hiding this comment.
I wonder if we should be setting a bootoption here? It will depend on what the UEFI firmware detects and adds to the EFI variables.
This is a bit more complicated as virtio-scsi controllers support multiple targets, whereas exsting block device drivers supported only one drive per controller instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code was written by Patrick van der Linden of EFit Partners. I made some modifications and wrote the new manpage content.
This is a bit more complicated as virtio-scsi controllers support multiple targets, whereas exsting block device drivers supported only one drive per controller instance.
This increases the total number of disks to 99, but it preserves the existing logic for non-scsi disks and adds a fatal error when the amount of 16 non-scsi disks is exceeded.