Skip to content

Text tools (select, find)#1

Merged
omonien merged 3 commits intoomonien:masterfrom
HemulGM:master
Mar 31, 2026
Merged

Text tools (select, find)#1
omonien merged 3 commits intoomonien:masterfrom
HemulGM:master

Conversation

@HemulGM
Copy link
Copy Markdown
Contributor

@HemulGM HemulGM commented Nov 22, 2025

No description provided.

@omonien
Copy link
Copy Markdown
Owner

omonien commented Dec 2, 2025

Can you explain a bit more what your changes are about? I will still be on the road for the next several days, so I have limited time to check the code in full.

@HemulGM
Copy link
Copy Markdown
Contributor Author

HemulGM commented Dec 2, 2025

Add new functions from dll
image

Added methods for working with text for the "page". Including with FPDF_TEXTPAGE
image

Added a new class that represents the search query. You can destroy it whenever you want, and destroying the page won't lead to an error either.
image

Added a scrollbar for scrolling pages in the view control. And I added an example of performing a search to the example. + added a test method for highlighting what was found.
image
image

@omonien
Copy link
Copy Markdown
Owner

omonien commented Mar 31, 2026

Thanks @HemulGM - solid implementation! Clean interface-based design with IPageSearch and proper lifecycle management via FSearchNotifies. The CurrentPage visibility change is a welcome improvement. Merging this now.

@omonien omonien marked this pull request as draft March 31, 2026 13:58
@omonien omonien marked this pull request as ready for review March 31, 2026 15:13
@omonien omonien merged commit 652cceb into omonien:master Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants