Added functionality to more easily extract plain text#3
Closed
TheOriginalBytePlayer wants to merge 6 commits intoomonien:masterfrom
Closed
Added functionality to more easily extract plain text#3TheOriginalBytePlayer wants to merge 6 commits intoomonien:masterfrom
TheOriginalBytePlayer wants to merge 6 commits intoomonien:masterfrom
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
|
Hi @TheOriginalBytePlayer, thanks for your interest in the project and for taking the time to submit this PR! After careful review, I've decided not to merge this in its current form for the following reasons:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the PDF document API, focusing on enhancing the usability and functionality of the
TPdfDocumentclass and exposing additional PDFium text extraction capabilities. The most important changes include updating the way PDF documents are loaded, adding indexed page access, and exposing a new function for retrieving character bounding boxes.Enhancements to PDF document loading and access:
TPdfDocument.LoadFromFilefrom a procedure to a function that returns a boolean indicating success, and updated its implementation to set the result based on loading status and page count. [1] [2] [3]Pagesproperty toTPdfDocumentfor direct access to pages by index.PDFium API exposure:
FPDFText_GetCharBoxto expose PDFium's character bounding box retrieval functionality.