🎨ErrorCode 기반 공통 응답 및 예외 처리 리팩터링#63
Open
mango0422 wants to merge 12 commits intoone-day-one-problem:developfrom
Open
🎨ErrorCode 기반 공통 응답 및 예외 처리 리팩터링#63mango0422 wants to merge 12 commits intoone-day-one-problem:developfrom
mango0422 wants to merge 12 commits intoone-day-one-problem:developfrom
Conversation
…-bug-submissions-테이블에서-user_id가-null로-저장되는-문제 ✨ 특정 API 엔드포인트에 인증 요구 추가
…velop 🚀 Merge 'develop' branch into 'main' branch
…velop 🚀 Merge 'develop' branch into 'main' branch
…x/problem-solved-count 🐛 문제 해결 사용자 수 집계 로직을 수정하여 문제 해결 사용자 수가 정확하게 저장되도록 개선
…velop 🚀 Merge 'develop' branch into 'main' branch
…-improve-문제-목록-조회-api-성능-개선 ⚡ DB 인덱싱을 통한 문제 목록 API 성능 개선
…tfix/cicd 🚑 SonarQube 사망으로 CI/CD 파이프라인 수정
namsh1125
reviewed
Nov 20, 2025
Contributor
namsh1125
left a comment
namsh1125
left a comment
There was a problem hiding this comment.
onCreate, onBadRequest를 지우고 error 메서드를 만드셨으면 onUnauthorized, onForbidden도 error 메서드로 통합하는 것이 좋아 보입니다 :)
namsh1125
reviewed
Nov 20, 2025
Contributor
namsh1125
left a comment
namsh1125
left a comment
There was a problem hiding this comment.
ProblemNotFoundException, SubmissionNotFoundException와 같이 8번째 줄에 한 줄 띄우면 좋을 것 같습니다 :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 개요
enum 타입으로 에러코드 및 메시지를 분리하였습니다.
🔍 변경사항
ErrorCodeenum 도입으로 성공/에러 메시지 + HTTP 상태 코드 중앙 관리BaseResponse구조를statusCode, message, data로 단순화하고ErrorCode와 연동ErrorCode기반으로 응답하도록 변경⏳ 작업 내용
GlobalExceptionHandler에error(ErrorCode, message)헬퍼 추가 및 전역 예외 처리 로직 통일ProblemController,SubmissionController,UserController,TokenController응답을ErrorCode.xxx.toResponseEntity(data)로 변경ProblemNotFoundException,InvalidAnswerFormatException,SubmissionNotFoundException에ErrorCode필드 추가 및 기본 메시지 enum에서 조회하도록 수정📝 논의사항
BaseResponse.isSuccess필드 제거 OK 여부isSuccess를 참조하지 않고statusCode만으로 처리해도 되는지 확인 필요