Increasing mongodb safety#11
Open
MirkoBonadei wants to merge 8 commits into
Open
Conversation
We want to have a single point to create instances of MongoClient connections. The goal behind this idea is to force the "w" => "majority" to all the recruiter2 connections.
I can create a mongodb object
Contributor
Author
|
The build is broken because on TravisCI we have not configured a replica set. We are going to fix in the afternoon. |
Contributor
Author
|
Ok, after an upgrade of the testing environment to |
We are going to have only one factory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have created a Factory to force the
woption of the MongoClient tomajority.The default
wis1and in case of failover there is the possibility that the newPRIMARYdoes not have the writes of the previous one. This is a potential issue for our queue engine so we forcew=majorityeverywhere.