[improve][client] PIP-234: Support sharing the memory limit controller across multiple isolated Pulsar client instances#29
Closed
oneby-wang wants to merge 11 commits intomasterfrom
Closed
Conversation
97bddcf to
c029b7c
Compare
7fd4399 to
43296cf
Compare
f5b95ee to
ad11ba7
Compare
fde6fc6 to
67f6a78
Compare
15 tasks
ec00a8f to
1f4a41f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes apache#25212
Motivation
apache#19074 enables sharing of Pulsar client resources across multiple isolated Pulsar client instances, but this solution lacks limiting the total amount of memory across all of the Pulsar client instances. This PR introduces a shared
MemoryLimitControllersolution for PIP-234.Modifications
MemoryLimitControllerto support registering multiple trigger callbacks and deregistering the callback when the client instance gets closed.MemoryLimitControllerinPulsarClientSharedResourcesandPulsarClientSharedResourcesBuilder, then apply the sharedMemoryLimitControllertoPulsarClientImplBuilder.Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: