Conversation
Migrate to uv and set minimum python version to 3.10
qkaiser
force-pushed
the
onekey-baseline
branch
2 times, most recently
from
869d3fe to
01e0b25
Compare
Add CI action to pull git lFS file. Add CI worfklow to run pre-commit, tests, and type checking + codeQL analysis.
qkaiser
force-pushed
the
onekey-baseline
branch
from
01e0b25 to
6314bc4
Compare
qkaiser
requested review from
e3krisztian,
kissgyorgy,
kukovecz,
orosam and
vlaci
|
Can you split this up by topic please? It would be much easier and faster to review and merge them one by one. |
| ] | ||
|
|
||
| ignore = [ | ||
| "A005", # stdlib-module-shadowing: E.g. `unblog.logging` collides with stdlib `logging`. It's okay for us |
There was a problem hiding this comment.
I'd drop this line, or fix the bogus comment.
There was a problem hiding this comment.
These files are small. Why complicate with git lfs?
| @@ -0,0 +1,3 @@ | |||
| version https://git-lfs.github.com/spec/v1 | |||
| oid sha256:af2667929275f3c34f731d066c3756ac97943e31fa753532eddd32e3da83c2c3 | |||
| size 214 | |||
There was a problem hiding this comment.
This is a git-lfs file, but LFS is not configured, yet (and maybe we should not at all?).
test/samples/bsd_multi_names.ar
Outdated
| #1/84 1364081511 1000 100 100644 84 ` | ||
| a_very_long_name_for_the_gnu_type_header_so_it_can_overflow_the_standard_name_length#1/96 1364081511 1000 100 100644 96 ` | ||
| a_very_long_name_for_the_gnu_type_header_so_it_can_overflow_the_standard_name_length_with_space No newline at end of file | ||
| a_very_long_name_for_the_gnu_type_header_so_it_can_overflow_the_standard_name_length_with_space |
There was a problem hiding this comment.
This end of line change looks wrong.
test/samples/contents.ar
Outdated
| @@ -4,4 +4,3 @@ test_in_file_1 | |||
|
|
|||
| file2/ 1364071325 1000 100 100644 15 ` | |||
| test_in_file_2 | |||
There was a problem hiding this comment.
This end of line change looks wrong.
| the data contained in the archive. Archived files are accessible via file-like | ||
| objects. | ||
|
|
||
| """arpy module can be used for reading `ar` files' headers, as well as accessing the data contained in the archive. Archived files are accessible via file-like objects. |
| if self.gnu_table[position].endswith(b"/"): | ||
| self.gnu_table[position] = self.gnu_table[position][ | ||
| :-1 | ||
| ] # remove trailing '/' |
There was a problem hiding this comment.
Since Python 3.9 (https://peps.python.org/pep-0616/) there is bytes.removesuffix.
self.gnu_table[position] = filename.removesuffix(b"/")Original trigger was: I hate when lines are split like this due to "line length"
| for _key in ar.archived_files: | ||
| pass |
There was a problem hiding this comment.
The original code printed something at this place.
3 participants
This establish our baseline by implementing the following:
The code logic was not modified. All code modifications were made by
ruffor inserted to address issues reported bypyright.