Conversation
LEB1/LEB2 contains multiple MasterNodes. The one with the largest cmt_no needs to be scanned, as that is the currently activated one.
qkaiser
force-pushed
the
fix-master-node-error
branch
from
1b7e735 to
2ccfb28
Compare
Contributor
Author
|
I'm okay with the changes but since I had to open this I can't approve. Asking for @e3krisztian |
e3krisztian
reviewed
Mar 23, 2026
e3krisztian
approved these changes
Mar 23, 2026
qkaiser
force-pushed
the
fix-master-node-error
branch
from
2ccfb28 to
8d4e881
Compare
Calling os.utime with follow_symlinks to False on Windows errors out with Python >= 3.12 on Windows. See https://bugs.python.org/issue46490
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEB1/LEB2 contains multiple MasterNodes. The one with the largest cmt_no needs to be scanned, as that is the currently activated one.
Initially opened at #116 but it was opened from a fork's main branch and when I touched it it closed the entire PR.