This repository was archived by the owner on Aug 26, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Create edit view #13
Open
will-nemo
wants to merge
2
commits into
master
Choose a base branch
from
create-edit-view
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Create edit view #13
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| .edit-mode-container { | ||
| display: flex; | ||
| flex-direction: column; | ||
|
|
||
| & .button-module { | ||
| display: flex; | ||
| flex-direction: row; | ||
| align-self: flex-start; | ||
| } | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import React from 'react'; | ||
|
|
||
| export default function DisplayView() { | ||
| /************************************ | ||
| * Render | ||
| ************************************/ | ||
|
|
||
| return ( | ||
| <> | ||
| </> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import React, { useState } from 'react'; | ||
| import './App.scss'; | ||
|
|
||
| import EditView from './EditView'; | ||
| import DisplayView from './DisplayView'; | ||
|
|
||
| /************************************ | ||
| * Constants | ||
| ************************************/ | ||
|
|
||
| const EDIT_VIEW = 'EDIT'; | ||
| const DISPLAY_VIEW = 'DISPLAY'; | ||
|
|
||
| export default function EditMode({width = '100%', height = '500px'}) { | ||
| /************************************ | ||
| * State | ||
| ************************************/ | ||
|
|
||
| const [view, setView] = useState(EDIT_VIEW); | ||
|
|
||
| /************************************ | ||
| * Render | ||
| ************************************/ | ||
|
|
||
| return ( | ||
| <div className='edit-mode-container' style={{width: width, height: height}}> | ||
| <div className='button-module'> | ||
| <button onClick={() => {setView(EDIT_VIEW)}}>Edit</button> | ||
| <button onClick={() => {setView(DISPLAY_VIEW)}}>Preview</button> | ||
| </div> | ||
| { view === EDIT_VIEW ? <EditView /> : <DisplayView /> } | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import React from 'react'; | ||
|
|
||
| export default function EditView({onValueChange, ...rest}) { | ||
| /************************************ | ||
| * Render | ||
| ************************************/ | ||
|
|
||
| return ( | ||
| <textarea style={{height: 'inherit'}} {...rest} onChange={onValueChange}></textarea> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import React from 'react'; | ||
| import EditMode from './EditMode'; | ||
|
|
||
| export default function LeifdownApp() { | ||
| /************************************ | ||
| * Render | ||
| ************************************/ | ||
|
|
||
| return ( | ||
| <EditMode /> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why you're setting the styling here as opposed to CSS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The height of the 'EditMode' will be determined by the user passing down a height. This text area will calculate the height based off that passed in height (will be shorter at some point). Since it's dynamic i should be doing this styling inline.
Also from what i've seen these npm packages don't usually use style sheets. Need to determine the best way to do this. Might make the most sense to keep all functionality on a component since it's the one thing being imported