feat(config): implement configurable scheduling system #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add configurable assignment_interval_days to Settings struct (1-365 days, defaults to 14) - Create config/default.toml for centralized configuration - Update db::should_run() to accept configurable interval parameter - Replace hardcoded 14-day interval with configuration-driven approach - Add comprehensive config tests with serial execution (7 tests) - Add serial_test dev dependency to prevent env var test interference - Fix doctests in people_config.rs Workflow optimization: - Remove inefficient daily cron trigger from GitHub Actions - Default to manual workflow_dispatch for better resource efficiency - Add APP__ASSIGNMENT_INTERVAL_DAYS environment variable support - Document scheduling strategies (manual, external scheduler, daily cron) Documentation: - Update README.md with configuration guide and scheduling options - Add cross-reference in docs/PEOPLE_DATA.md - Document configuration precedence (env vars > files > defaults) Test results: All 41 tests passing - 7 lib tests + 9 main tests + 7 config tests + 16 people_config tests + 2 doctests Backward compatible: Existing setups continue using 14 days automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow optimization:
Documentation:
Test results: All 41 tests passing
Backward compatible: Existing setups continue using 14 days automatically.