Receive external LUID#1
Open
ThreeDeeJay wants to merge 6 commits into
Open
Conversation
Owner
|
I've now merged the nv3d-glass branch, as I think it's ready. You can update this PR when ready :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if it's ICD-specific, but apparently VKS3D has to pass its LUID to NV3D for it to work.
So I had to make some minor changes to make that happen instead of hardcoding the LUID which I initially did for testing so you might wanna squash the PR when merging, given it is correct, of course.
This is what worked for me, but if there's already a better way or you plan to make a more robust implementation, feel free to close.
EDIT: Oh, and I'm not sure if it was the best idea to target the nv3d-glass branch, but it was kinda weird to target the main branch before nv3d-glass got merged. So if you'd prefer, I could close this PR and re-submit once nv3d-glass gets merged.