Fix Cadence parse error in FlowEVMBridgeCustomAssociations precondition message#209
Merged
joshuahannan merged 2 commits intoApr 9, 2026
Merged
Conversation
…ix Cadence parse error on testnet The previous message used string interpolation with ?? and escaped quotes which is not supported by the Cadence version running on testnet. Simplified to remove the duplicate association lookup from the error message.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Since the precondition check already confirms the EVM address exists in associationsByEVMAddress, the force-unwrap is safe and avoids the escaped quote syntax that caused parse errors on testnet.
joshuahannan
deleted the
fix/custom-associations-precondition-parse-error
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saveCustomAssociation(line 131) to fix a parse error on testnet??with escaped quotes inside string interpolation, which is not supported by the Cadence version running on testnet (though it passes on the local emulator)Root Cause
The Cadence version on testnet is older than the one used by the local emulator, causing a syntax that works in tests to fail on deployment.
Before:
"EVM Address \(evmContractAddress.toString()) already has a custom association with \(self.associationsByEVMAddress[evmContractAddress.toString()]?.identifier ?? \"unknown type\")"After:
"EVM Address \(evmContractAddress.toString()) already has a custom association with \(self.associationsByEVMAddress[evmContractAddress.toString()]!.identifier)"Test plan