Skip to content

Remove finalized as a success state #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lealobanov merged 2 commits into from
Jul 11, 2025
Merged

Remove finalized as a success state #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db86d1f
Remove finalized as a success state
lealobanov Jul 11, 2025
44c4c44
Remove finalized as a success state
lealobanov Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ allprojects {
}

group = "org.onflow.flow"
val defaultVersion = "0.0.25"
val defaultVersion = "0.0.26"
version = System.getenv("GITHUB_REF")?.split('/')?.last() ?: defaultVersion
}

Expand Down
7 changes: 1 addition & 6 deletions flow/src/commonMain/kotlin/org/onflow/flow/apis/TransactionsApi.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,6 @@ internal class TransactionsApi(val baseUrl: String) : ApiBase() {
try {
val result = getTransactionResult(transactionId)
when (result.status ?: TransactionStatus.EMPTY) {
TransactionStatus.FINALIZED -> {
// Transaction is finalized, return immediately without checking for errors
// since finalized transactions haven't been executed yet
return result
}
TransactionStatus.EXECUTED -> {
// Transaction is executed, return result
return result
Expand All @@ -114,7 +109,7 @@ internal class TransactionsApi(val baseUrl: String) : ApiBase() {
return result
}
TransactionStatus.EXPIRED -> throw RuntimeException("Transaction expired")
TransactionStatus.EMPTY, TransactionStatus.UNKNOWN, TransactionStatus.PENDING -> {
TransactionStatus.EMPTY, TransactionStatus.UNKNOWN, TransactionStatus.PENDING, TransactionStatus.FINALIZED -> {
// Treat empty/unknown/pending status as still processing, continue polling
attempts++
// Use exponential backoff with jitter for first few attempts, then stabilize
Expand Down
Loading