chore(openshell): re-vendor proto to v0.0.71#147
Open
onsails wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR re-vendors the OpenShell protobuf definitions in right-openshell to upstream tag v0.0.69, updating the API/wire surface that right-openshell compiles against and communicates with.
Changes:
- Updated vendored upstream tracking metadata to v0.0.69.
- Updated
openshell.prototo include new provider profile update RPCs/messages, a newProviderProfile.resource_versionfield, and replacedSandboxSpec.gpuwithSandboxSpec.resource_requirements(plus new resource requirement messages).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/right-openshell/proto/UPSTREAM.md | Bumps recorded upstream proto tag/fetch timestamp to v0.0.69. |
| crates/right-openshell/proto/openshell/openshell.proto | Updates the vendored OpenShell API surface (new RPC/messages, new resource_version, and breaking SandboxSpec field-9 change). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1094
to
1099
| ProviderProfileDiscovery discovery = 9; | ||
| // Storage resource version for custom profiles. Built-in profiles and new | ||
| // profile files use 0. Gateway responses set this for stored custom profiles. | ||
| // Update calls use this for optimistic concurrency. | ||
| uint64 resource_version = 10; | ||
| } |
Comment on lines
321
to
+326
| openshell.sandbox.v1.SandboxPolicy policy = 7; | ||
| // Provider names to attach to this sandbox. | ||
| repeated string providers = 8; | ||
| // Request NVIDIA GPU resources for this sandbox. | ||
| bool gpu = 9; | ||
| // Portable resource requirements used by the gateway for driver selection | ||
| // and by drivers for provisioning. | ||
| ResourceRequirements resource_requirements = 9; |
af4fc08 to
1e6a5d1
Compare
09e0a0c to
05772f4
Compare
05772f4 to
46e0d9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated re-vendor of the OpenShell protos to v0.0.71.
buf breaking(PACKAGE)cargo check -p right-openshellbuf breaking output
cargo check (tail)
A BREAKING or FAILED result means upstream changed the wire/API shape.
Audit
SandboxReadinessand any code decoding moved/removed fields, then bumpMIN_OPENSHELL_VERSIONand the CIOPENSHELL_VERSIONpin as needed.This bot surfaces drift only — it does not fix Rust. Full CI runs on this PR only
when
BOT_PR_TOKEN(a fine-grained PAT) is configured as a repo secret;otherwise bot-authored PRs don't trigger downstream workflows. Either way, the
openshell-proto-compatworkflow run itself goes RED whencargo checkfails,so a failing proto bump is visible in the Actions tab even without full CI.