Use latin1, --pure_barcode and no universal_newlines#19
Open
parmegv wants to merge 1 commit intooostendo:masterfrom
Open
Use latin1, --pure_barcode and no universal_newlines#19parmegv wants to merge 1 commit intooostendo:masterfrom
parmegv wants to merge 1 commit intooostendo:masterfrom
Conversation
latin1 allows us to handle (ASCON cipher) ciphertext pure_barcode is required to get binary data universal_newlines was assuming all \r were \n, but with encrypted data it is not the case.
Owner
|
I guess this looks like you've customized it for a specific application -- that's great, and I'm glad it works for you. I guess to accept this I would ask that all of these changes could be parameter controlled in the decode() function similar to what you did for pure_barcode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
latin1 allows us to handle ciphertext (tested with ASCON cipher).
pure_barcode is required to get binary data
universal_newlines was assuming all \r were \n, but with encrypted
data it is not the case.