Skip to content

fix: avoid Windows title bar overlap in RightPanel #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xuxu777xu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: avoid Windows title bar overlap in RightPanel #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/components/layout/RightPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use client";

import { useCallback } from "react";
import { useCallback, useSyncExternalStore } from "react";
import { HugeiconsIcon } from "@hugeicons/react";
import { StructureFolderIcon, PanelRightCloseIcon } from "@hugeicons/core-free-icons";
import { Button } from "@/components/ui/button";
Expand All @@ -21,6 +21,9 @@ interface RightPanelProps {
export function RightPanel({ width }: RightPanelProps) {
const { panelOpen, setPanelOpen, workingDirectory, sessionId, previewFile, setPreviewFile } = usePanel();
const { t } = useTranslation();
const emptySubscribe = useCallback(() => () => {}, []);
const mounted = useSyncExternalStore(emptySubscribe, () => true, () => false);
const isWindows = mounted && /windows/i.test(navigator.userAgent);

const handleFileAdd = useCallback((path: string) => {
window.dispatchEvent(new CustomEvent('attach-file-to-chat', { detail: { path } }));
Expand Down Expand Up @@ -50,7 +53,7 @@ export function RightPanel({ width }: RightPanelProps) {

if (!panelOpen) {
return (
<div className="flex flex-col items-center gap-2 bg-background p-2">
<div className={`flex flex-col items-center gap-2 bg-background px-2 pb-2 ${isWindows ? "pt-12" : "pt-2"}`}>
<Tooltip>
<TooltipTrigger asChild>
<Button
Expand All @@ -71,7 +74,7 @@ export function RightPanel({ width }: RightPanelProps) {
return (
<aside className="hidden h-full shrink-0 flex-col overflow-hidden bg-background lg:flex" style={{ width: width ?? 288 }}>
{/* Header */}
<div className="flex h-12 mt-5 shrink-0 items-center justify-between px-4">
<div className={`flex h-12 ${isWindows ? "mt-12" : "mt-5"} shrink-0 items-center justify-between px-4`}>
<span className="text-[11px] font-semibold uppercase tracking-wider text-muted-foreground">
{t('panel.tasks')}
</span>
Expand Down
Loading