fix: correct Feishu bridge image MIME detection#232
Open
peng2132 wants to merge 1 commit intoop7418:mainfrom
Open
fix: correct Feishu bridge image MIME detection#232peng2132 wants to merge 1 commit intoop7418:mainfrom
peng2132 wants to merge 1 commit intoop7418:mainfrom
Conversation
bridge/adapters: - detect the real MIME type and file extension for Feishu-downloaded images from magic bytes and response headers - stop forcing every Feishu image attachment to image/png and .png before sending it to Claude tests: - add regression coverage for JPEG, PNG, and WebP Feishu media detection root cause: - the Feishu bridge always labeled downloaded images as image/png regardless of the actual bytes - sending screenshots/photos through the Feishu bridge could make Claude Code exit with code 1 and show a misleading provider/image support error even though the provider supported multimodal input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
image/pngand.pngReproduction
On the Feishu bridge, sending a screenshot/photo could make the app return the generic error below even though the configured provider supports multimodal input and the same image works through Telegram:
Telegram handled the same image successfully. The visible error message was misleading; the real issue was a bridge adapter bug.
Root Cause
The Feishu bridge always labeled downloaded images as
image/pngregardless of the actual bytes. That incorrect MIME declaration could break multimodal Claude Code requests and surface the generic exit-code-1 provider/image-support error.Verification
npm run test