fix: centralize stale model IDs into single CLAUDE_MODELS constant + fix status bar model display#251
Open
jasonjaclyn2017 wants to merge 3 commits intoop7418:mainfrom
Open
Conversation
|
@jasonjaclyn2017 is attempting to deploy a commit to the op7418's projects Team on Vercel. A member of the Team first needs to authorize it. |
jasonjaclyn2017
changed the title
Hardcoded model IDs (claude-sonnet-4-20250514, claude-opus-4-20250514) were scattered across 7+ files as fallbacks. These were stale after the CLI update to v2.1.73 which resolves aliases to the new model IDs (claude-sonnet-4-6, claude-opus-4-6). - Add src/lib/model-ids.ts with CLAUDE_MODELS + DEFAULT_MODEL_ID (client-safe, no fs/db imports — avoids Next.js bundling errors) - provider-resolver.ts: import + re-export from model-ids.ts, replace hardcoded envModels and toAiSdkConfig fallback - model-context.ts: derive context window map from CLAUDE_MODELS (import from model-ids.ts to stay client-safe) - skills/search/route.ts: derive MODEL_MAP from CLAUDE_MODELS - checkin-processor.ts, onboarding-processor.ts, media/jobs/plan/route.ts: use DEFAULT_MODEL_ID for last-resort fallback One place to update when new models release. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When Claude runs a long script, the SSE connection can be silently dropped by transport layers (OS TCP stack, Electron internals, HTTP idle timeouts). Previously this caused the stream to appear "completed" with partial content and no error message. Two-part fix: Server-side heartbeat (claude-client.ts): - Send keep_alive SSE events every 30s independently of SDK activity - Prevents intermediate layers from considering the connection idle - Timer properly cleaned up in all exit paths including cancel() Client-side detection (useSSEStream.ts + stream-session-manager.ts): - Track whether the server's 'done' SSE event was received - If reader finishes without 'done', treat as connection drop - Show "Connection lost" error and clear stale SDK session - Flush residual SSE buffer after reader signals done i18n (en.ts + zh.ts): - Add streaming.connectionDrop translation key Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chat/page.tsx used statusData.model (the SDK's resolved wire ID like claude-opus-4-20250514) instead of statusData.requested_model (the alias the user selected). This caused the "Connected (...)" status to flash a stale/misleading model ID. useSSEStream.ts already had the correct priority — this aligns chat/page.tsx to match. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jasonjaclyn2017
force-pushed
the
fix/centralize-model-ids
branch
from
b6eac8b to
cc1ed3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardcoded model IDs (claude-sonnet-4-20250514, claude-opus-4-20250514) were scattered across 7+ files as fallbacks. These were stale after the CLI update to v2.1.73 which resolves aliases to the new model IDs (claude-sonnet-4-6, claude-opus-4-6).
(e.g. "claude-opus-4-20250514") instead of the user's selected model.
Aligns with useSSEStream.ts which already had the correct priority.
One place to update when new models release.