Expand Laravel log file detection to support flexible filenames#500
Merged
Expand Laravel log file detection to support flexible filenames#500
Conversation
Update isPossiblyLaravelLogFile() regex to match any laravel-*.log pattern, enabling detection of custom channel logs like laravel-mychannel.log
arukompas
force-pushed
the
feature/flexible-laravel-log-detection
branch
2 times, most recently
from
ad45089 to
98fa660
Compare
arukompas
force-pushed
the
feature/flexible-laravel-log-detection
branch
from
98fa660 to
f2bb537
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isPossiblyLaravelLogFile()regex to match anylaravel-*.logpatternlaravel-mychannel.log,laravel-errors.log, etc.LogTypeRegistrarTest plan
vendor/bin/pest tests/Unit/LogTypeRegistrarTest.php- all 12 tests pass