fix: use template-based winget submit for jtk releases#89
Merged
Conversation
wingetcreate update fetches the published manifest from microsoft/winget-pkgs, which still has RelativeFilePath: jira-ticket-cli.exe from before the rename. The zip now contains jtk.exe, causing "Nested installer not found" errors. Switch to a template-based approach: copy local manifest templates, substitute version/checksum placeholders, and use wingetcreate submit. This bypasses the auto-detection entirely and gives full control over manifest content. Also updates installer template to use distinct checksum placeholders (CHECKSUM_AMD64_PLACEHOLDER, CHECKSUM_ARM64_PLACEHOLDER) to avoid PowerShell -replace ordering ambiguity, and updates README with correct binary names and URL patterns.
The test-winget CI was using [regex]::Replace with 0{64} pattern to
substitute checksums one at a time. Now that the jtk installer template
uses distinct named placeholders (CHECKSUM_AMD64_PLACEHOLDER,
CHECKSUM_ARM64_PLACEHOLDER), update the test to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wingetcreate update --submitwith a template-based approach usingwingetcreate submitfor jtk winget releasesjira-ticket-cli.exe— but the zip now containsjtk.exe, causing "Nested installer not found" errorsCHECKSUM_AMD64_PLACEHOLDER,CHECKSUM_ARM64_PLACEHOLDER) in the installer template to avoid PowerShell-replaceordering ambiguityTest plan
fix:orfeat:commit touching Go code) and verify the winget job passesCloses #88