chore: conform cli-common to the library profile; document keyring dependency cost#58
Conversation
…pendency cost - ci.yml: read the Go version from go.mod via go-version-file (ci.md $3) instead of a hardcoded literal that can drift - Makefile: check now includes build, so a green local check predicts a green CI run (repo-layout.md $2.1) - add AGENTS.md and CLAUDE.md as thin peer indexes and docs/development.md for repo-local facts (agent-implementation.md $2, repo-layout.md $2.1) - working-with-secrets $1.10: document the measured dependency cost of byteness/keyring's unconditional 1Password imports (63 packages, ~10.6 MB, no DCE); remediation committed in #57 - output-and-rendering $10: record the family-wide color verification result — no CLI forces color onto non-TTY output (audited at pinned SHAs; slck has no color paths at all) Closes #55
Findings
|
…ckages in release policy
|
No test coverage concerns. Every file in this PR is docs, CI config, a Makefile tweak, or agent-context files — there is no testable behavior change. The CI workflow update (go-version-file), the Makefile build step addition, the two new agent entrypoints, and the documentation updates to |
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 245f18f
Summary
No issues found.
2 PR discussion threads considered.
Completed in 2m 15s | $1.18 | sonnet | daemon 0.2.127 | Glorfindel
| Field | Value |
|---|---|
| Model | sonnet |
| Reviewers | hybrid-synthesis, documentation:docs-reviewer, harness-engineering:harness-architecture-reviewer, harness-engineering:harness-enforcement-reviewer, harness-engineering:harness-knowledge-reviewer |
| Engine | claude · sonnet |
| Reviewed by | pr-review-daemon · monit-pr-reviewer |
| Duration | 2m 15s wall · 2m 12s compute (Reviewers: 1m 42s · Synthesis: 30s) |
| Cost | $1.18 (estimated) |
| Tokens | 210.2k in / 12.8k out |
| Turns | 10 |
Per-workstream usage
| Workstream | Model | In | Out | Cache read | Cache create | Cost |
|---|---|---|---|---|---|---|
| hybrid-synthesis | sonnet | 37.0k | 1.2k | 13.8k | 23.2k (1h) | $0.16 |
| documentation:docs-reviewer | sonnet | 44.2k | 5.4k | 11.2k | 33.0k (1h) | $0.28 |
| harness-engineering:harness-architecture-reviewer | sonnet | 41.4k | 658 | 0 | 41.4k (1h) | $0.26 |
| harness-engineering:harness-enforcement-reviewer | sonnet | 43.6k | 2.5k | 11.2k | 32.4k (1h) | $0.24 |
| harness-engineering:harness-knowledge-reviewer | sonnet | 44.0k | 3.1k | 11.2k | 32.8k (1h) | $0.25 |
Re-reviews only run when @monit-reviewer is re-requested as a reviewer — push as many commits as you need, then re-request when ready. PRs targeting branches other than main, master are skipped, even when @monit-reviewer is re-requested.
FindingsNo findings. The post-daemon changes stay within #55’s intended scope. The two prior issues are resolved: |
Implements #55 under the revised scope (see the plan and quantification comments on the issue): the keyring dependency finding is documented here with measured numbers — the upstream fix is committed separately in #57 — and cli-common is conformed to the new library-repo profile from #54.
Changes
ci.yml— both jobs now usego-version-file: go.mod(ci.md§3); the hardcoded'1.26'literal was the exact drift the rule bans.Makefile—checkgainsbuild, so a green local check predicts a green CI run (repo-layout.md§2.1). The monolithic build-test CI job is deliberately untouched (remains a cataloguedci.md§8 divergence).AGENTS.md/CLAUDE.md— thin peer indexes peragent-implementation.md§2 (point todocs/development.mdanddocs/README.md; no cross-reference between them; local source-of-truth links since this repo is the standards home).docs/development.md— repo-local facts: package map with the doc sections each package implements,make check, hermetic-test rules, manual-tag/release-train policy.working-with-secrets.md§1.10 — "Known dependency cost" paragraph: byteness/keyring compiles its 1Password openers (→ wazero, jaeger) into every consumer; measured 2026-06-11 at keyring v1.9.3: 63 packages, ~10.6 MB attributable symbols in the shippedslckbinary, no dead-code elimination. Remediation tracked in chore: upstream opt-out build tag to ByteNess/keyring for the 1Password backends #57.output-and-rendering.md§10 — color verification pass result (downstream of docs: resolve standards-family contradictions, gaps, and stale references (review decisions applied) #54's isatty flip), recorded with audited SHAs.Color audit evidence (W4)
Audited every color path — color-package imports plus a raw-ANSI-literal sweep (
\x1b[,\033[,�) of non-test source — at these SHAs:shared/view/view.goonlyNoColordisables onlyinternal/view/view.go, root flag plumbingtermenv.Asciion no-colorinternal/view/view.goNoColordisables onlyinternal/view/view.gocolor.NoColor = trueon no-colorZero raw-ANSI writers, zero
color.NoColor = false/EnableColor/ forced renderer profiles family-wide. Library TTY-detection defaults are in effect everywhere → conformant with the amended §8.Also on the issue
govulncheckon slack-chat-api: 0 reachable vulnerabilities; 13 module-level findings in required-but-uncalled modules (the predicted audit noise).Closes #55