feat: rethink credential storage data model and UX#357
Merged
Conversation
Closes #356 Verified in tmux cr-356-c3: go test ./internal/configedit ./internal/cmd/credentialcmd ./internal/view; go build ./...
Closes #356 Verified in tmux cr-356-c4: go test ./internal/configedit ./internal/cmd/credentialcmd ./internal/view; go build ./...
Update the top-level CLI no-leak fixture to exercise explicit credential stores instead of the removed ambient backend flags. Closes #356
rianjs
changed the title
Prune unused legacy credential-store helpers and add targeted lint suppressions for non-secret credential names and the 1Password CLI probe. Closes #356
Keep unavailable root-menu actions out of keyboard focus so disabled rows do not render as active green selections. Closes #356
Render a short notice before 1Password desktop discovery can trigger external permission prompts. Closes #356
Render the OS credential store as read-only inventory and keep editable secrets-storage targets limited to configured stores and configure-new actions. Closes #356
Show discovered 1Password desktop accounts and vaults as dependent fields in the secrets-storage editor instead of one flat account/vault list. Keep manual account and manual vault fallback paths stable when discovery is incomplete. Closes #356
Render built-in credential stores as a read-only inventory block and remove the redundant 1Password details section from the secrets-storage editor. Closes #356
Drop the wrapper heading and routing copy from the desktop 1Password secrets-storage editor while keeping the account context on the vault picker when discovery returns one account. Closes #356
Use organization and personal 1Password account URL examples in the desktop account URL help text. Closes #356
Print concise availability lines for built-in OS storage, 1Password desktop discovery, and pass password store probing before opening the secrets-storage editor. Closes #356
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #356.
Summary
local-os) while making every secret-writing flow choose a destinationcodereview/...credential names instead0.5Verification
cr-356-c7rango test ./internal/..., credential-store list smoke, obsolete command rejection checks, and explicit destination checks; status0cr-356-versionrango test ./...,scripts/verify-package-render.sh, version assertion for0.5, and top-level CLI tests; status0go test ./internal/cmd/credentialcmd,go test ./internal/view ./internal/cmd/configcmd, andgo test ./cmd/cr ./internal/version ./internal/cmd/root