Skip to content

feat: sign slck darwin binaries with a stable code-signing identity #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rianjs merged 1 commit into from
Jun 3, 2026
Merged

feat: sign slck darwin binaries with a stable code-signing identity #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,7 @@ jobs:
chocolatey-api-key: ${{ secrets.CHOCOLATEY_API_KEY }}
winget-token: ${{ secrets.WINGET_GITHUB_TOKEN }}
linux-dispatch-token: ${{ secrets.LINUX_PACKAGES_DISPATCH_TOKEN }}
macos-cert-p12: ${{ secrets.MACOS_CERT_P12 }}
macos-cert-password: ${{ secrets.MACOS_CERT_PASSWORD }}
macos-cert-cn: ${{ secrets.MACOS_CERT_CN }}
macos-cert-leaf-sha: ${{ secrets.MACOS_CERT_LEAF_SHA }}
7 changes: 7 additions & 0 deletions .goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ builds:
- -X github.com/open-cli-collective/slack-chat-api/internal/version.Version={{.Version}}
- -X github.com/open-cli-collective/slack-chat-api/internal/version.Commit={{.Commit}}
- -X github.com/open-cli-collective/slack-chat-api/internal/version.Date={{.Date}}
# macOS code-signing — stable DR so Keychain "Always Allow" survives brew upgrade
# (cli-common distribution.md §2A). Logic + identity live in open-cli-collective/.github
# (macos-codesign-setup), which exports CODESIGN_DARWIN_SCRIPT (absolute). Unset in
# local builds → signing skipped.
Comment thread
rianjs marked this conversation as resolved.
hooks:
post:
- cmd: bash -c 'f="${CODESIGN_DARWIN_SCRIPT:-}"; [ -n "$f" ] && [ -x "$f" ] && exec "$f" "$0" "$1"; echo "skip codesign (no CODESIGN_DARWIN_SCRIPT)"' "{{ .Path }}" "{{ .Os }}"
- id: slck-unix-win
main: ./cmd/slck
binary: slck
Expand Down
2 changes: 1 addition & 1 deletion version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.1
3.2
Loading