chore: align darwin codesign hook to the fail-loud form#186
Merged
Conversation
slck carried the original simple darwin codesign hook; the other five family CLIs (cfl/jtk/gro/nrq/cr) use the hardened fail-loud form, where CODESIGN_DARWIN_SCRIPT set-but-missing or non-executable errors instead of silently skipping. Make slck's hook byte-identical to theirs so the convention is uniform. YAML-only — not a gated release path.
Collaborator
Author
|
Codex architect review (continuity session from the signing initiative) The hook is now byte-identical to the refined fail-loud convention. Unset env still no-ops for local builds; set-but-missing/non-executable fails before an unsigned intended-to-sign build can proceed. STATUS: blockers=0 majors=0 minors=0 nits=0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slck carried the original simple darwin codesign hook; the other five family CLIs (cfl/jtk/gro/nrq/cr) ship the hardened fail-loud form — where
CODESIGN_DARWIN_SCRIPTset-but-missing or non-executable errors instead of silently skipping. This makes slck's hook byte-identical to theirs so the convention (cli-commondistribution.md §2A) is uniform across all six repos..goreleaser.yamlis not a gated release path → no release is cut.goreleaser check -f .goreleaser.yamlpasses.