Skip to content

test: cover slack keychain metadata#189

Merged
rianjs merged 1 commit into
mainfrom
fix/188-keychain-metadata
Jun 20, 2026
Merged

test: cover slack keychain metadata#189
rianjs merged 1 commit into
mainfrom
fix/188-keychain-metadata

Conversation

@rianjs

@rianjs rianjs commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • bump cli-common to the immutable pseudo-version containing test: cover macOS keychain metadata cli-common#64
  • add a Darwin+cgo gated empirical test for slck Keychain metadata
  • seed stale metadata for both bot_token and user_token, then verify the adapter overwrite path repairs concrete labels/descriptions

Verification

  • go list -m github.com/open-cli-collective/cli-common
  • go mod tidy -diff
  • go test ./internal/keychain
  • SLCK_KEYCHAIN_METADATA_TEST=1 go test ./internal/keychain -run TestKeychainMetadataGated -count=1 -v
  • go test ./...
  • make test
  • make verify

Closes #188

@rianjs

rianjs commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator Author

Findings

  • Minor: The only new regression guard is opt-in (SLCK_KEYCHAIN_METADATA_TEST=1), so normal go test ./... / CI runs will skip it. That makes this a manual proof, not automated coverage, and a future metadata regression could still merge unless you also wire a Darwin job or an always-on assertion. internal/keychain/keychain_metadata_darwin_test.go
  • Minor: The test only exercises the stale-metadata overwrite path. It never verifies the first-time SetBotToken/SetUserToken write path on an absent item, so a bug where initial creation stops writing concrete labels/descriptions would still pass. internal/keychain/keychain_metadata_darwin_test.go

@rianjs rianjs force-pushed the fix/188-keychain-metadata branch from b13b169 to 4ccdeb1 Compare June 20, 2026 12:31
@monit-reviewer

Copy link
Copy Markdown

PR review failed and the daemon has stopped retrying for this commit. I am removing my pending review request to stop the automated review cycle. Re-request @monit-reviewer to retry, or push a new commit and re-request.

@monit-reviewer monit-reviewer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Review

Reviewed commit: 4ccdeb1

Manually approved via CLI.

@rianjs rianjs merged commit 1ba4277 into main Jun 20, 2026
9 checks passed
@rianjs rianjs deleted the fix/188-keychain-metadata branch June 20, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix macOS Keychain metadata for credstore items

2 participants